-
Notifications
You must be signed in to change notification settings - Fork 351
Add content resolver for the new ContentBundle architecture #7611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content resolver for the new ContentBundle architecture #7611
Conversation
a43dcec
to
cff5665
Compare
As discussed with @Prokyonn teaser and link content type are a bit differently. But we said that we will go with a |
@Prokyonn for the PropertyResolvers inside bundle I would remove the -Sulu\Bundle\ContactBundle\Infrastructure\Sulu\Content\PropertyResolver\Resolver\AccountSelectionPropertyResolver
+Sulu\Bundle\ContactBundle\Infrastructure\Sulu\Content\PropertyResolver\AccountSelectionPropertyResolver |
Yes that totally makes sense 👍 |
Just as a random thought. Could you also design the system so that it is easy to profile and debug these functions simmilar to the |
@mamazu as now all are service tags it is straight forward over the
|
3b54d40
to
62239fe
Compare
As discussed we will target the 3.0 for the new resolver and merge other bundles into that branch for easier maintainance, but that will be its own Pull requests. |
5beb399
to
8b33c50
Compare
* Make resolver and loader internal and final * Add Tag and add Category loader tests
* Add ImageMap Property Resolver * Add single collection and multi collection property resolver
bee9051
to
cd473bd
Compare
Moved TODO list into own issue: #7672 |
What's in this PR?
Adds new
PropertyResolver
andResourceLoader
to use for theContentBundle
Why?
ContentBundle will introduce a new architecture to more efficiently resolve content.
To Do