Skip to content

Remove deprecated Urlizer #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Oct 5, 2024

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no (already deprecated)
Fixed tickets -
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

Replacing the Urlizer with the service that the deprecation already states.

Why?

No need to keep the old code.

Long term

We're already using the symfony/string package which has a slugger function. Maybe we could use that.

@mamazu mamazu force-pushed the remove_url_slugfier branch from 6f14a06 to fa2896f Compare October 7, 2024 11:27
@mamazu mamazu changed the title Remove deprecated Urlizer Remove deprecated Urlizer Oct 7, 2024
@mamazu mamazu added the DX Affecting the end developer label Oct 9, 2024
@alexander-schranz alexander-schranz merged commit 08f73a7 into sulu:3.0 Nov 26, 2024
7 of 9 checks passed
@alexander-schranz
Copy link
Member

@mamazu Thank you!

@alexander-schranz alexander-schranz added the Technical Debt Impacts code quality, no or just small impact on end developers and users label Nov 26, 2024
@mamazu mamazu deleted the remove_url_slugfier branch November 26, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants