Custom urls without phpcr (Admin Panel) #7570
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
021bead to
0201ae6
Compare
be94c3e to
28f8007
Compare
mamazu
commented
Sep 6, 2024
src/Sulu/Bundle/CustomUrlBundle/Controller/CustomUrlHistoryController.php
Outdated
Show resolved
Hide resolved
mamazu
commented
Sep 6, 2024
mamazu
commented
Sep 6, 2024
src/Sulu/Component/CustomUrl/Routing/CustomUrlDefaultsProvider.php
Outdated
Show resolved
Hide resolved
703af71 to
088c517
Compare
81d25db to
129c7b7
Compare
mamazu
commented
Sep 29, 2024
Comment on lines
+66
to
+68
| <custom-urls> | ||
| <custom-url>localhost/*</custom-url> | ||
| </custom-urls> |
There was a problem hiding this comment.
Remove before merging.
eba27cb to
44bb7b6
Compare
44bb7b6 to
6b6ae67
Compare
cffa861 to
cea63a4
Compare
mamazu
commented
Jun 19, 2025
mamazu
commented
Jun 19, 2025
| /** | ||
| * @internal | ||
| */ | ||
| final class CustomUrlTrashSubscriber implements EventSubscriberInterface |
There was a problem hiding this comment.
This is nothing CustomUrl specific. Maybe this makes sense to move to the trash bundle itself.
30a03d1 to
6427a30
Compare
|
Also, I'm currently copying over request/response JSON from the 2.6 branch to keep the Backwards compatibility and I notice that the endpoint also returns a 200 in case of an error and then just a JSON with the error information: Do we want to keep that behavior? Or risk a BC break for this? |
Sure should be then a |
776a63f to
a8e604c
Compare
d837730 to
67d541e
Compare
67d541e to
02a8716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Replacing the custom url implementation of phpcr with some doctrine entities.
Why?
phpcr should be removed in the next major version and we can really simplify the logic here.
Todo
Admin (Prio 1)