Migrate rest routings to default symfony routing files of PreviewBundle #7526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
alexander-schranz
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Please register the new routes in config/routes/ directory instead of the old one:
diff --git a/config/routes/sulu_admin.yaml b/config/routes/sulu_admin.yaml
index 0b19447d89..161249cc7e 100644
--- a/config/routes/sulu_admin.yaml
+++ b/config/routes/sulu_admin.yaml
@@ -82,16 +82,16 @@ sulu_route_api:
prefix: /admin/api
sulu_preview:
- resource: "@SuluPreviewBundle/Resources/config/routing.yml"
+ resource: "@SuluPreviewBundle/Resources/config/routing.yaml"
prefix: /admin/preview
sulu_preview_api:
type: rest
- resource: "@SuluPreviewBundle/Resources/config/routing_api.yml"
+ resource: "@SuluPreviewBundle/Resources/config/routing_api.yaml"
prefix: /admin/api
sulu_preview_public:
- resource: "@SuluPreviewBundle/Resources/config/routing_public.yml"
+ resource: "@SuluPreviewBundle/Resources/config/routing_public.yaml"
prefix: /admin/p
sulu_search:Still there seems unexpected changes / missing routes?:
Make sure the bin/console debug:router --format json is the same for new routing files and the rest routing files.
797004d to
221bd8e
Compare
alexander-schranz
approved these changes
Jun 7, 2025
221bd8e to
9268354
Compare
9268354 to
939cdbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
See ticket # 7434
All Routes that are needed