Skip to content

Migrate rest routings to default symfony routing files of TrashBundle #7514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025

Conversation

TheCadien
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes # 7434
Related issues/PRs # 7434
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

See ticket # 7434

All Routes that are needed

  • sulu_trash.get_trash-items GET ANY ANY /admin/api/trash-items.{_format}
  • sulu_trash.get_trash-item GET ANY ANY /admin/api/trash-items/{id}.{_format}
  • sulu_trash.delete_trash-item DELETE ANY ANY /admin/api/trash-items/{id}.{_format}
  • sulu_trash.post_trash-item_trigger POST ANY ANY /admin/api/trash-items/{id}.{_format}

@TheCadien TheCadien added the DX Affecting the end developer label Jul 7, 2024
path: /trash-items.{_format}
methods: GET
controller: sulu_trash.trash_item_controller::cgetAction
format: json|csv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if that's an alternative syntax but in the compiled route collection the syntax is:

Suggested change
format: json|csv
requirements: { _format: json|csv }

Oliver Kossin and others added 2 commits June 7, 2025 19:48
Migrate rest routings to default symfony routing files of TrashBundle
@alexander-schranz alexander-schranz force-pushed the migrate-rest-routing-trash branch from a567202 to 043b034 Compare June 7, 2025 17:51
@alexander-schranz alexander-schranz merged commit 4c87722 into sulu:2.6 Jun 7, 2025
9 checks passed
@alexander-schranz alexander-schranz added the Technical Debt Impacts code quality, no or just small impact on end developers and users label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants