Migrate rest routings to default symfony routing files of TagBundle #7511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
mamazu
suggested changes
May 22, 2025
| path: /tags/{id}.{_format} | ||
| controller: sulu_tag.tag_controller::getAction | ||
| methods: GET | ||
| format: json |
There was a problem hiding this comment.
I don't know what this format key is supposed to do. If you want to specify what values it can have it should be something like
sulu_tag.get_tag:
requirements: { _format: json|csv }
There was a problem hiding this comment.
format does the same as options: _format so its obsolete if already defined in options
Co-authored-by: mamazu <14860264+mamazu@users.noreply.github.com>
26efed5 to
bf8aeaa
Compare
Comment on lines
+6
to
+7
| requirements: | ||
| _format: json|csv |
There was a problem hiding this comment.
this was missing as it was currently handled by type: rest but that should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
See ticket # 7434
All Routes that are needed