Skip to content

Using tagged_iterator for RuleCollections #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2.6
Choose a base branch
from
Open

Using tagged_iterator for RuleCollections #7405

wants to merge 3 commits into from

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented May 6, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets -
Related issues/PRs #7402
License MIT
Documentation PR -

What's in this PR?

Using the tagged iterator concept to reduce the amount of code that sulu has to create.

Why?

See linked issue.

Example Usage

<argument type="tagged_iterator" tag="testing" />

More info on Symfony Tagged Services

@mamazu mamazu force-pushed the tagged_iterator_rules branch from c0f6564 to 6160893 Compare May 6, 2024 12:59
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels May 6, 2024
@mamazu mamazu mentioned this pull request May 6, 2024
Open
16 tasks
@mamazu mamazu force-pushed the tagged_iterator_rules branch 3 times, most recently from 0c4a28c to d50979e Compare May 10, 2024 22:11
@mamazu mamazu force-pushed the tagged_iterator_rules branch 2 times, most recently from b0d62a5 to 428d8b2 Compare July 12, 2024 08:20
@mamazu mamazu force-pushed the tagged_iterator_rules branch 4 times, most recently from d9a123e to 0529684 Compare July 25, 2024 10:34
@mamazu mamazu force-pushed the tagged_iterator_rules branch from e742c62 to 179514b Compare January 8, 2025 13:27
@mamazu
Copy link
Contributor Author

mamazu commented Feb 20, 2025

@mamazu This should use a tagged_locator instead.

@mamazu
Copy link
Contributor Author

mamazu commented Feb 25, 2025

This is probably going to be a bc break so let's leave it as a tagged_iterator for now.

@mamazu mamazu mentioned this pull request Apr 4, 2025
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mamazu