Using tagged_iterators for the markup listener
#7403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
commented
May 6, 2024
| public const SERVICE_ID = 'sulu_markup.response_listener'; | ||
|
|
||
| /** | ||
| * @deprecated Use the value instead | ||
| */ | ||
| public const TAG_NAME = 'sulu_markup.parser'; |
There was a problem hiding this comment.
Maybe we could move this to the ParserInterface as a constant. Could be helpful for people who use PHP to Configure their app?
738dfae to
ff726c6
Compare
16 tasks
2047f0f to
5786b9b
Compare
|
@alexander-schranz This should be BC break free now. We can still remove those classes in 3.0 but that's a different MR. |
5f13ec7 to
32ee9eb
Compare
32ee9eb to
85f1f03
Compare
85f1f03 to
b9d17de
Compare
3dedd16 to
f97c26a
Compare
f97c26a to
29df2d7
Compare
29df2d7 to
923e314
Compare
|
@mamazu This should be using a tagged_locator instead because we do not need all services here. |
923e314 to
d986090
Compare
mamazu
commented
Apr 21, 2025
Comment on lines
76
to
101
| $container = new class([ | ||
| 'html' => $this->markupParser->reveal(), | ||
| ]) implements ContainerInterface { | ||
| public function __construct(private array $services) | ||
| { | ||
| } | ||
|
|
||
| public function get($id) | ||
| { | ||
| return $this->services[$id]; | ||
| } | ||
|
|
||
| public function has($id): bool | ||
| { | ||
| return \array_key_exists($id, this->services); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Maybe this should be generalized or we could pull this from the container if it's a KernelTestCase
57a6e85 to
2a9d31e
Compare
2a9d31e to
73779de
Compare
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Using the tagged iterator concept to reduce the amount of code that sulu has to create.
Why?
See linked issue.
Example Usage
More info on Symfony Tagged Services
To Do