Update jest to version 27 #6361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
commented
Nov 9, 2021
| @@ -9,7 +9,7 @@ jest.mock('../../stores/metadataStore', () => ({ | |||
| getSchema: jest.fn(), | |||
| })); | |||
|
|
|||
| test('Create a MemoryFormStore with schema', (done) => { | |||
| test('Create a MemoryFormStore with schema', () => { | |||
There was a problem hiding this comment.
a test cannot return a promise and use the done callback at the same time anymore:
https://jestjs.io/blog/2021/05/25/jest-27#features-coming-with-breaking-changes
niklasnatter
commented
Nov 9, 2021
| @@ -43,7 +43,7 @@ | |||
| "@wojtekmaj/enzyme-adapter-react-17": "^0.6.1", | |||
| "autoprefixer": "^9.8.6", | |||
| "babel-eslint": "^10.0.2", | |||
| "babel-jest": "^26.3.0", | |||
| "babel-jest": "^27.3.1", | |||
There was a problem hiding this comment.
unfortunately, it looks like the new jest-circus runner fails when comparing a normal array with an observable array now. this leads to a lot of errors like this when running the tests:
FAIL src/Sulu/Bundle/AdminBundle/Resources/js/containers/FieldBlocks/tests/FieldBlocks.test.js
● Should pass new value to the BlockCollection if value prop is updated
expect(received).toEqual(expected) // deep equality
Expected: [{"text": "One", "type": "default"}]
Received: serializes to the same string
There was a problem hiding this comment.
i suspect that this problem could be solved by updating to a new version of mobx. but unfortunately we are stuck at version 4 until the next major release (see #6343) 😕
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR updates the
jestpackage from version 26 to version 27. See the official release blog for a list of changes between the versions.