Feature/command improvements #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show error message instead and exit with status 1
- Handle case where requested role does not exist - Handle case where username already exists
| @@ -43,13 +43,25 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| $doctrine = $this->getContainer()->get('doctrine'); | |||
| $em = $doctrine->getManager(); | |||
| $now = new \Datetime(); | |||
There was a problem hiding this comment.
Handled by Doctrine event hooks.
7810b43 to
77decd9
Compare
| foreach ($query->getArrayResult() as $roleEntity) { | ||
| $roles[] = $roleEntity['name']; | ||
| } | ||
| $roleNames = $this->getRoleNames(); |
There was a problem hiding this comment.
Moved this to repository.
77decd9 to
5dd2156
Compare
| @@ -28,5 +28,10 @@ | |||
| </join-columns> | |||
| </many-to-one> | |||
|
|
|||
| <lifecycle-callbacks> | |||
| <lifecycle-callback type="prePersist" method="beforeSave" /> | |||
There was a problem hiding this comment.
@dantleech why call the method like event?
5dd2156 to
7d4d681
Compare
wachterjohannes
added a commit
that referenced
this pull request
Jan 12, 2015
Feature/command improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 commits which fix some issues in the user/role commands
preUpdateandprePersisthooks to set the created + changed fields on theRoleentity.Tasks:
Informations: