Skip to content

Upgrade ckeditor to version 34.2.0 and postcss to version 8 #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 11, 2022
Merged

Upgrade ckeditor to version 34.2.0 and postcss to version 8 #6688

merged 9 commits into from
Jul 11, 2022

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jul 10, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets parts of #6343
Related issues/PRs #
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Upgrade ckeditor to version 34.2.0.

Why?

Supporting the latest ckeditor features and plugins.

TODO

@alexander-schranz alexander-schranz changed the title Upgrade ckeditor to version 34.2.0 Upgrade ckeditor to version 34.2.0 and postcss to version 8 Jul 10, 2022
@alexander-schranz alexander-schranz force-pushed the feature/upgrade-ckeditor branch from 05a0490 to c3030a0 Compare July 10, 2022 12:47
@alexander-schranz alexander-schranz mentioned this pull request Jul 10, 2022
Merged
@alexander-schranz alexander-schranz force-pushed the feature/upgrade-ckeditor branch from c3030a0 to 9e89ac2 Compare July 10, 2022 12:55
@alexander-schranz alexander-schranz added the DX Affecting the end developer label Jul 10, 2022
alexander-schranz
alexander-schranz commented Jul 10, 2022
View reviewed changes
src/Sulu/Bundle/AdminBundle/Resources/js/containers/CKEditor5/CKEditor5.js
if (disabled) {
this.editorInstance.enableReadOnlyMode('disabled');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-editor-isreadonly-has-no-setter

@alexander-schranz alexander-schranz mentioned this pull request Jul 10, 2022
Merged
5 tasks
@alexander-schranz alexander-schranz mentioned this pull request Jul 10, 2022
Merged
@alexander-schranz
Copy link
Member Author

alexander-schranz commented Jul 10, 2022 •
edited
Loading

There are 2 ways of getting this merged. First would be create a fork of the used postcss plugin based on existi compatible pull request here: madeleineostoja/postcss-hexrgba#33
Second one would be go to alternative plugin. Like the following but it does make the code a lot harder to read and requires a rewrite of all rgba usages currently https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-color-hex-alpha.

I personally would go with fork exist postcss-hexrgba package.

/cc @sulu/core-team

@alexander-schranz alexander-schranz mentioned this pull request Jul 10, 2022
Open
1 task
@niklasnatter
Copy link
Contributor

There are 2 ways of getting this merged. First would be create a fork of the used postcss plugin based on existi compatible pull request here: madeleineostoja/postcss-hexrgba#33 Second one would be go to alternative plugin. Like the following but it does make the code a lot harder to read and requires a rewrite of all rgba usages currently https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-color-hex-alpha.

Looks like madeleineostoja/postcss-hexrgba#33 was merged a few hours ago, so we dont need to fork 🥳

niklasnatter
niklasnatter reviewed Jul 11, 2022
View reviewed changes
niklasnatter
niklasnatter reviewed Jul 11, 2022
View reviewed changes
@niklasnatter niklasnatter mentioned this pull request Jul 11, 2022
Draft
@alexander-schranz @niklasnatter
Apply suggestions from code review
8a45562 
Co-authored-by: niklasnatter <niklas.natter@gmail.com>
@niklasnatter niklasnatter merged commit c4bea23 into sulu:2.5 Jul 11, 2022
@alexander-schranz alexander-schranz deleted the feature/upgrade-ckeditor branch July 11, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@niklasnatter niklasnatter niklasnatter left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
DX Affecting the end developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-schranz @niklasnatter