Fixed checkbox read for preview #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb956f7 to
c797c0d
Compare
|
Falsy values do not produce preview update |
|
@danrot fixed |
87353b7 to
70cc29f
Compare
|
After clicking on a checkbox you still have to click somewhere else for the preview to update, I guess that's because there is no focus out event otherwise. Maybe we should adapt the dom filter for checkboxes? |
|
@danrot i have added a changed event for radio and checkbox |
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
Informations: