[ContentBundle] Prefix contentbundle template path #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a94736d to
66c704d
Compare
|
@wachterjohannes I think you opened an issue about this? |
|
@dantleech i dont think i have opened a ticket for that ... but this is a good idea to handle it in a Compiler Pass! |
|
@dantleech PR is ok can you merge it with develop? |
|
@wachterjohannes its not handled in a compiler pass, but uses the bundle configuration prefix feature. will rebase and merge :) |
66c704d to
1b8bf93
Compare
dantleech
added a commit
that referenced
this pull request
Nov 10, 2014
…le-template-path [ContentBundle] Prefix contentbundle template path
dantleech
added a commit
to sulu/sulu-standard
that referenced
this pull request
Nov 11, 2014
dantleech
added a commit
to sulu/sulu-standard
that referenced
this pull request
Nov 11, 2014
wachterjohannes
added a commit
to sulu/sulu-standard
that referenced
this pull request
Nov 11, 2014
…-path Updated for sulu/sulu#524
2 tasks
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically adds the internal content bundle templates directory to the
sulu_coreconfiguration.This removes the need to define
structures.content.paths.xxx.path: %kernel.root_dir%/vendor/foo/bar/bar/bar/Content/templates