Feature/search delete from index #581

dantleech · 2014-11-19T16:27:07Z

Search deindexing on node delete and delete event from content mapper

Added loadShallowStructureForNode method to ContentMapper
Send out event for each deleted node and provide a Shallow structure to the listening events (in addition
to the PHPCR node being deleted)

Tasks:

test coverage
gather feedback for my changes

Depends

Initial ElasticSearch support massiveart/MassiveSearchBundle#14 (for test adapter fixes)

Informations:

Q	A
Tests pass?	[yes
Fixed tickets	fixes #578, fixes #271
BC Breaks	NO
Doc	NONE

dantleech · 2014-11-19T16:29:54Z

src/Sulu/Component/Content/Mapper/ContentMapper.php

+                Structure::NODE_TYPE_CONTENT
+            )
+        );
+        $structure->setWebspaceKey($webspaceKey);


I would really have loved to not have done this.

Structures should support lazy loading

I have repeated yet more logic here because the loadByNode stuff requires far more work than I can achieve in the scope of this feature.

Viva la revolution.

So you have basically duplicated this code? Why not put it into a separate function, and call it at the other place as well?

alexander-schranz · 2014-12-11T12:43:23Z

@dantleech when will this be merged? I need the delete event for my project.
/cc @chirimoya

wachterjohannes · 2014-12-15T10:24:03Z

@dantleech the tests are failing! could you take a look at this?

dantleech · 2014-12-15T10:28:13Z

yeah. will do it this afternoon.

dantleech · 2014-12-15T15:25:33Z

UPGRADE.md

+
+Because they are applied otherwise add a permission value of 120 for
+`sulu.security.roles`, `sulu.security.groups` and `sulu.security.users` to one
+user to change the settings in the UI


Lets not make upgrade instructions as bullet points.. we will need to give code examples sometimes and it just gets messy.

/cc
@wachterjohannes @danrot @chirimoya

dantleech · 2014-12-16T12:58:17Z

src/Sulu/Bundle/SearchBundle/EventListener/ContentMapperSubscriber.php

@@ -56,4 +63,17 @@ public function onNodeSave(ContentNodeEvent $event)
            $this->searchManager->deindex($structure);
        }
    }
+
+    public function onNodePreDelete(ContentNodeDeleteEvent $event)


dantleech · 2014-12-16T13:06:07Z

Tests are good. @wachterjohannes @alexander-schranz

danrot · 2015-01-07T10:58:14Z

What's the state of this PR?

dantleech · 2015-01-07T12:20:11Z

was ready. needs a rebase.

dantleech · 2015-01-08T07:55:36Z

Hmm.. actually there are still a few things to tidy up

dantleech · 2015-01-08T08:04:26Z

src/Sulu/Bundle/SearchBundle/EventListener/ContentMapperSubscriber.php

+
+        if ($structure->getNodeState() === Structure::STATE_PUBLISHED) {
+            $this->searchManager->index($structure);
+        } else {


else is not required

dantleech · 2015-01-08T08:31:34Z

src/Sulu/Bundle/SearchBundle/Tests/Functional/BaseTestCase.php

@@ -24,9 +24,6 @@ class BaseTestCase extends SuluTestCase
    public function setUp()
    {
        $this->initPhpcr();
-        $fs = new Filesystem;
-
-        $fs->remove(__DIR__ . '/../app/data');


Seems fine without this.

Is really all data deleted after every run?

I delete before. It gives you the chance to debug, if you delete after you need to do things like die() to inspect the state of the database.

But tbh I am not sure why I removed this, I just noticed that it did no harm. Will verify.

dantleech · 2015-01-08T08:37:24Z

Ready for review and merge.

dantleech · 2015-01-08T09:28:29Z

SnippetBundle test failing.

danrot · 2015-01-12T07:55:29Z

Can you fix them?

danrot · 2015-01-12T08:17:04Z

CHANGELOG.md

@@ -2,6 +2,9 @@ CHANGELOG for Sulu
 ==================

 * dev-develop
+    * FEATURE     #581 [SearchBundle]   Structures deindexed on delete
+    * FEATURE     #581 [Content]  NODE_SAVE renamed to NODE_POST_SAVE


Would write ContentBundle here, for the sake of consistency

Its not ContentBundle though, its the Component.

Should align it though

dantleech · 2015-01-12T10:43:44Z

@danrot updated

- Added NODE_DELETE event - Renamed NODE_SAVE event to NODE_POST_SAVE - SearchBundle deindexes on Structure delete

* Adjust documentation to configure live-generation of URL * Add section about template specific route schema

dantleech added the in progress label Nov 19, 2014

dantleech changed the title ~~Feature/search delete from index~~ [WIP] Feature/search delete from index Nov 19, 2014

dantleech reviewed Nov 19, 2014
View reviewed changes

chirimoya assigned dantleech Nov 19, 2014

dantleech added review and removed in progress labels Nov 20, 2014

dantleech changed the title ~~[WIP] Feature/search delete from index~~ Feature/search delete from index Nov 20, 2014

dantleech force-pushed the feature/search-delete-from-index branch from c5aa185 to ceb44dd Compare December 15, 2014 15:16

dantleech reviewed Dec 15, 2014
View reviewed changes

dantleech force-pushed the feature/search-delete-from-index branch 2 times, most recently from 1cac3a3 to f49c4eb Compare December 16, 2014 12:41

dantleech reviewed Dec 16, 2014
View reviewed changes

dantleech force-pushed the feature/search-delete-from-index branch from f49c4eb to b7d7cf2 Compare December 16, 2014 13:02

dantleech force-pushed the feature/search-delete-from-index branch from b7d7cf2 to b618bb9 Compare January 8, 2015 07:53

dantleech reviewed Jan 8, 2015
View reviewed changes

dantleech force-pushed the feature/search-delete-from-index branch from b618bb9 to 991e5b6 Compare January 8, 2015 08:30

dantleech reviewed Jan 8, 2015
View reviewed changes

dantleech force-pushed the feature/search-delete-from-index branch from 991e5b6 to 9bfa3ee Compare January 8, 2015 08:37

dantleech force-pushed the feature/search-delete-from-index branch from 9bfa3ee to d9c29b9 Compare January 8, 2015 08:38

danrot reviewed Jan 12, 2015
View reviewed changes

dantleech force-pushed the feature/search-delete-from-index branch 3 times, most recently from 1d8d0dc to d7b0c6d Compare January 12, 2015 10:43

ErfanEbrahimnia force-pushed the develop branch from 6a930a4 to 05d05cd Compare January 12, 2015 12:04

Node delete and search deindexing

926027d

- Added NODE_DELETE event - Renamed NODE_SAVE event to NODE_POST_SAVE - SearchBundle deindexes on Structure delete

dantleech force-pushed the feature/search-delete-from-index branch from d7b0c6d to 926027d Compare January 12, 2015 14:36

danrot merged commit 926027d into develop Jan 12, 2015

danrot removed the review label Jan 12, 2015

danrot deleted the feature/search-delete-from-index branch January 12, 2015 14:40

alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this pull request Nov 14, 2024

Adjust documentation to configure live-generation of URL (sulu#581)

0bc2ce8

* Adjust documentation to configure live-generation of URL * Add section about template specific route schema

Feature/search delete from index #581

Feature/search delete from index #581

Uh oh!

Conversation

dantleech commented Nov 19, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexander-schranz commented Dec 11, 2014

Uh oh!

wachterjohannes commented Dec 15, 2014

Uh oh!

dantleech commented Dec 15, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dantleech commented Dec 16, 2014

Uh oh!

danrot commented Jan 7, 2015

Uh oh!

dantleech commented Jan 7, 2015

Uh oh!

dantleech commented Jan 8, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dantleech commented Jan 8, 2015

Uh oh!

dantleech commented Jan 8, 2015

Uh oh!

danrot commented Jan 12, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dantleech commented Jan 12, 2015

Uh oh!

Uh oh!