Fix preview renderer preview attribute and xml http request #4146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64bf293 to
e22e8b6
Compare
wachterjohannes
requested changes
Sep 14, 2018
| @@ -158,6 +158,9 @@ public function render($object, $id, $webspaceKey, $locale, $partial = false, $t | |||
| } | |||
|
|
|||
| $attributes = $this->routeDefaultsProvider->getByEntity(get_class($object), $id, $locale, $object); | |||
| $attributes['object'] = $object; | |||
There was a problem hiding this comment.
will be set by the RouteDefaultsProvider
| @@ -158,6 +158,9 @@ public function render($object, $id, $webspaceKey, $locale, $partial = false, $t | |||
| } | |||
|
|
|||
| $attributes = $this->routeDefaultsProvider->getByEntity(get_class($object), $id, $locale, $object); | |||
| $attributes['object'] = $object; | |||
| $attributes['preview'] = true; | |||
| $attributes['partial'] = $partial; | |||
There was a problem hiding this comment.
will be used by the WebsiteController has to be here
|
@wachterjohannes test added |
486a7c8 to
568aad1
Compare
wachterjohannes
approved these changes
Sep 17, 2018
568aad1 to
faba8f3
Compare
|
@wachterjohannes merge conflicts fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove the server variable which symfony use the indicate xmlhttprequest and set preview and the other attirbutes correctly.
Why?
XMLHttpRequest was true which shouldn't and preview was not longer set.