Set a timeout when purging caches #4121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chirimoya In theory this is OK for me, but I don't really have experience with what a sensible value for the timeout is. @gisostallenberg When does the request fail now? After the max execution time of PHP? And in the current master branch you still have to add a line in the |
|
@danrot, @chirimoya I will change the value to 5 seconds. The reasoning is that Sulu should take less than 3 seconds to spin up, but in some cases this might be to rigid. I'll also provide a |
The default behavior is to wait indefinitely (see http://docs.guzzlephp.org/en/stable/request-options.html#connect-timeout), which may result in a very long request once the caches need to be cleared, but a long responding host is set in the config (see https://github.com/sulu/sulu-minimal/blob/7887ff338657fa5148c56153030d835d0da02c49/app/Resources/webspaces/example.com.xml#L43)
3f5c9e9 to
7112c2c
Compare
|
@danrot, @chirimoya I updated the PR as promised. |
|
@gisostallenberg thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Set a timeout when purging caches
Why?
The default behavior is to wait indefinitely (see guzzle documentation), which
may result in a very long request once the caches need to be cleared, but a long responding host is set in the config (see example configuration)