Remove validation-state from rendered link #4109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acb7310 to
70b257e
Compare
|
Code looks good to me, but can you add a test to the @wachterjohannes Are there any more properties we should add to this list? |
The LinkTag adds an attribute named `validation-state` if the target is not published. After publishing the target page and not editing the link again the resulting link contains the invalid attribute.
70b257e to
faa639d
Compare
|
Hi @danrot, |
wachterjohannes
approved these changes
Aug 21, 2018
|
@reflexxion thanks for this contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LinkTag adds an attribute named
validation-stateif the target is not published.After publishing the target page and not editing the link again the resulting link contains the invalid attribute.
What's in this PR?
The LinkTag adds an attribute named
validation-stateif the target is not published.After publishing the target page and not editing the link again the resulting link contains the invalid attribute.
Why?
Invalid attribute is rendered