avoid returning the same id multiple times in filter query of smart content #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4f92e3 to
cf77f87
Compare
danrot
commented
Jul 17, 2018
| @@ -60,6 +60,7 @@ private function findByFiltersIds($filters, $page, $pageSize, $limit, $locale, $ | |||
|
|
|||
| $queryBuilder = $this->createQueryBuilder('c') | |||
| ->select('c.id') | |||
| ->distinct() | |||
There was a problem hiding this comment.
@chirimoya This was the easiest solution we could find. Another solution would be groupBy('id'). I have read that this might be faster in some situations, but I've used an EXPLAIN statement to check the execution plan, and they were identical for both solutions. So I decided to go with distinct, because it explains better what is actually happening here.
aa0820e to
608d6bd
Compare
This reverts commit 608d6bd.
7b1f4a0 to
0402d89
Compare
0402d89 to
cc58b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR avoids returning the same ID multiple times in the ID query of the smart content.
Why?
If a media has assigned Category A and B and a SmartContent using the
mediadata provider has an or filter on Category A and B, then the ID query from theDataProviderRepositoryTraitreturns the same media ID twice. That only matters if there is also a limit (either in the smart content overlay or using themax_per_pageparam in the template XML), because then less items will be returned in the final query.