Fix handling of authored date on safari #4025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e5e4df to
fcd7860
Compare
c138ce9 to
e8ee0b6
Compare
|
Code looks good from a style perspective, although I don't really know what the real problem was 🙈 And I can't test it, since I don't have a safari installed... Maybe @wachterjohannes or @chirimoya can check? |
danrot
approved these changes
Jun 18, 2018
wachterjohannes
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix handling of authored date on safari.
Why?
Currently you can't edit a authored date on safari with time it ends in NaN ...