Skip to content

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Dec 9, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets none
Related issues/PRs sulu/SuluFormBundle#211
License MIT
Documentation PR none

What's in this PR?

This PR add following methods:

  • ListViewBuilderInterface::addResourceStorePropertiesToListMetadata
  • ListViewBuilderInterface::addRequestParameters
  • FormViewBuilderInterface::addRequestParameters
  • FormOverlayListViewBuilderInterface::addRequestParameters
  • PreviewFormViewBuilderInterface::addRequestParameters

Why?

See PR in sulu-form-bundle.

BC Breaks/Deprecations

New methods in interfaces.

To Do

  • Add breaking changes to UPGRADE.md
  • JS tests
  • PHPUnit tests

@wachterjohannes wachterjohannes force-pushed the feature/resource-store-property-metadata-request branch 7 times, most recently from 5102080 to b59618e Compare December 9, 2019 09:23
@wachterjohannes wachterjohannes marked this pull request as ready for review December 9, 2019 12:08
@wachterjohannes wachterjohannes force-pushed the feature/resource-store-property-metadata-request branch 2 times, most recently from be5dc99 to 031d97e Compare December 12, 2019 13:08
@wachterjohannes wachterjohannes force-pushed the feature/resource-store-property-metadata-request branch from 031d97e to 5a2e410 Compare December 16, 2019 06:52
@wachterjohannes wachterjohannes force-pushed the feature/resource-store-property-metadata-request branch from 5a2e410 to cece4fe Compare December 16, 2019 08:51
@danrot danrot merged commit b3447ef into sulu:master Dec 16, 2019
@wachterjohannes wachterjohannes deleted the feature/resource-store-property-metadata-request branch December 16, 2019 12:13
@wachterjohannes wachterjohannes restored the feature/resource-store-property-metadata-request branch December 16, 2019 13:21
wachterjohannes added a commit to wachterjohannes/sulu that referenced this pull request Dec 16, 2019
…#4935)

* add method to add resource-store-properties to metadata-request

* update mysql version

* fix naming in deprecation message

* test version 8.0 for mysql

* revert change of mysql version
danrot pushed a commit that referenced this pull request Dec 16, 2019
… (#4950)

* add method to add resource-store-properties to metadata-request

* update mysql version

* fix naming in deprecation message

* test version 8.0 for mysql

* revert change of mysql version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants