-
Notifications
You must be signed in to change notification settings - Fork 350
Add method to add resource-store-properties to metadata-request #4935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danrot
merged 5 commits into
sulu:master
from
wachterjohannes:feature/resource-store-property-metadata-request
Dec 16, 2019
Merged
Add method to add resource-store-properties to metadata-request #4935
danrot
merged 5 commits into
sulu:master
from
wachterjohannes:feature/resource-store-property-metadata-request
Dec 16, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
5102080
to
b59618e
Compare
danrot
suggested changes
Dec 10, 2019
be5dc99
to
031d97e
Compare
danrot
suggested changes
Dec 13, 2019
031d97e
to
5a2e410
Compare
danrot
suggested changes
Dec 16, 2019
5a2e410
to
cece4fe
Compare
wachterjohannes
added a commit
to wachterjohannes/sulu
that referenced
this pull request
Dec 16, 2019
…#4935) * add method to add resource-store-properties to metadata-request * update mysql version * fix naming in deprecation message * test version 8.0 for mysql * revert change of mysql version
danrot
pushed a commit
that referenced
this pull request
Dec 16, 2019
… (#4950) * add method to add resource-store-properties to metadata-request * update mysql version * fix naming in deprecation message * test version 8.0 for mysql * revert change of mysql version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR add following methods:
ListViewBuilderInterface::addResourceStorePropertiesToListMetadata
ListViewBuilderInterface::addRequestParameters
FormViewBuilderInterface::addRequestParameters
FormOverlayListViewBuilderInterface::addRequestParameters
PreviewFormViewBuilderInterface::addRequestParameters
Why?
See PR in sulu-form-bundle.
BC Breaks/Deprecations
New methods in interfaces.
To Do