added template structure & mapper #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
replaces pull request https://github.com/sulu-cmf/SuluContentBundle/pull/2 |
|
@drotter ready to merge! |
|
The detail-specification should not be written as bullet point list |
| /** | ||
| * @return SessionInterface | ||
| */ | ||
| protected function getSession() |
There was a problem hiding this comment.
@wachterjohannes Is that really necessary? I think only the content types which really need the session should get it (shouldn't be that many, and they could get it by themeselves).
There was a problem hiding this comment.
In that case we could also get rid of this class, and let the complex content types just implement ContentTypeInterface. Then we don't have that many classes dependent on the container. /cc @chirimoya
There was a problem hiding this comment.
hmm ... I personally wouldn't remove the abstract class. May be useful in future and also for reflection or type hint.
There was a problem hiding this comment.
A very wise person told me once "never use reflections" :-P
However, what about the getSession-Method? I would prefer to let each content type decide on it's own if it needs this session or not.
There was a problem hiding this comment.
|
@chirimoya @drotter changed things that should be done before merge |
wachterjohannes
added a commit
that referenced
this pull request
Aug 14, 2014
Adjusted to new theme config
wachterjohannes
added a commit
that referenced
this pull request
Aug 14, 2014
Integrate husky auto complete list in ContentType
mmsbrggr
pushed a commit
that referenced
this pull request
Aug 14, 2014
[FEATURE] save last clicked category to restore the datagrid
wachterjohannes
added a commit
that referenced
this pull request
Oct 31, 2014
Adjusted to new theme config
wachterjohannes
added a commit
that referenced
this pull request
Oct 31, 2014
Integrate husky auto complete list in ContentType
mmsbrggr
pushed a commit
that referenced
this pull request
Oct 31, 2014
[FEATURE] save last clicked category to restore the datagrid
danrot
pushed a commit
that referenced
this pull request
Dec 5, 2016
* init automation-bundle * Implemented task-api (#1) * implemented task-api * fixed comments * Added ui to manage tasks (#2) * added automation-tab * fixed comments * added delete dialog and validation of date-picker * ID changed to guid and added locale (#4) * changed id type to uuid * added locale to task * Added php-task library (#3) * refactored task-controller cget * renamed task-name to handler-class * added automation-task-handler * added php-task to sulu-task * added document-handler (#6) * Added ui improvements (#5) * fixed missing locale for find * Devided tasks into a list for future and history list (#7) * devided tasks into a list for future (editable) and history (with status) * improved handler configuration and added central navigation provider for tab * included style for task-history list * UI fixes (#8) * fixed translations * removed sortable from all fields except schedule * added icons for started and running * added remove button to overlay * added security-context to ui * fixed comments * added document automation events (#9)
alexander-schranz
referenced
this pull request
in alexander-schranz/sulu
Feb 22, 2024
mamazu
added a commit
to mamazu/sulu
that referenced
this pull request
Apr 4, 2024
alexander-schranz
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Webspace settings frontend * Fix StyleCI * Fixed bug * PHPCR Implementation (#4) * Implementation finished * Add tests * Add ES indexing * Info just gray * Check for ES in test * Add install notes * Better doc * Better doc * Fix bug in addition webspaces preselect * Fixed bug * Dataprovider considers webspace settings (#5) * Implementation finished * Dataprovider considers webspace settings * Code clean up * Corrected property param * Update ArticleDataProvider.php * Resolve Sitemap correctly (#6) * Add Canonical Tag (#7) * Add Canonical Tag * Code clean up * Target webspace (#8) * Add targetWebspace to ViewDocument * Fixed test * Search Subscriber (#10) * ArticleSearchSubscriber * Code clean up * Fix tests * Add "ignoreWebspaces" param to twig extension (#9) * Add "ignoreWebspaces" param to twig extension * Code clean up * Finishing (#11) * Add UPGRADE note * Add NL translations * Add FR translation * Fix indention * Fix StyleCI * Page tree route (#12) * Page tree route * Disable webspace settings form * Fix StyleCI
alexander-schranz
pushed a commit
that referenced
this pull request
Nov 25, 2024
* added .idea folder to the .gitignore file * adjusted name in jmsserializer configuration * added seo-form xml * added seo model and interface * implemented seo-controller, find-seo-query and basic modify-seo-message * added form configuration in sulu-content-extension * added translations for seo-form * improved phpdoc in content-repository-interface and content-view-factory-interface * implemented seo query-handler and message-handler, implemented seo-repository, implemented seo-view and seo-view-factory, adjusted various files * automatically fixed coding style with phpcs * made seo-model properties nullable, implemented modify-seo-message-handler * removed handling of unlocalized seo-dimensions in message-handlers * renamed getAttributes-method to createAttributes in publish-content-message-handler to match naming in other handlers * added serializer configuration for seo-view class * return empty seo-view in the seo-controller when seo is not found to unbreak form in the frontend * implemented publish-seo-message and its handler, added orm configuration for seo-view model * made bool properties of seo model nullable * added phpunit and webmozart-assert plugin for phpstan * refactored contet-view-factory-test, added seo-view-factory-test * added modify-seo-message-test and publish-seo-message-test * added seo-test and find-seo-query-test * refactored find-content-query-handler-test, added find-seo-query-handler-test * refactored modify-content-message-handler-test, added modify-seo-message-handler * refactored publish-content-message-handler-test, added publish-seo-message-handler-test * fixed namespace in seo unit-test files * added abstract prefix for abstract controller classes, renamed getResourceKey method * added functional test setup, created basic content-controller test * automatically fixed coding style with php-cs * implemented abstract-content-controller-test * implemented abstract-seo-controller-test * added comment in get-action of abstract-seo-controller and abstract-content-controller * renamed publish-dimension method, added copy-attributes-from method in seo-interface and content-interface * renamed form-key of seo-form from seo to content_seo * added test cases for testCopyAttributesFrom mothod of content-interface and seo-interface * fixed service-id of structure-metadata-factory
Noah-Lhommedieu
referenced
this pull request
in Noah-Lhommedieu/sulu-cicd
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added template structure & mapper: