Skip to content

Allow user to be null for security expressions for debug #3850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Mar 16, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

It check if the tokenstorage can provide a user and don't throw an error then.

Why?

Some commands like debug:container, debug:router didn't work on specific routes or services.

Example:

bin/adminconsole debug:router sulu_admin_v2.resources

@alexander-schranz alexander-schranz changed the title Debug router problems Allow user to be null for security expressions for debug Mar 16, 2018
@alexander-schranz alexander-schranz force-pushed the bugfix/debug-router-problems branch from d0e99a4 to ea60a9d Compare March 16, 2018 10:59
Copy link
Contributor

@danrot danrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already finished? If yes a test is missing 😉

@alexander-schranz alexander-schranz force-pushed the bugfix/debug-router-problems branch from a55a8b2 to 245b99e Compare June 18, 2018 12:59
@alexander-schranz alexander-schranz force-pushed the bugfix/debug-router-problems branch from 245b99e to 971ff13 Compare June 18, 2018 13:00
@alexander-schranz alexander-schranz added this to the Release 1.6 milestone Jun 18, 2018
@alexander-schranz
Copy link
Member Author

@danrot tests for SecurityConfig added.

@danrot danrot merged commit 2c3a8c9 into sulu:release/1.5 Jun 19, 2018
@alexander-schranz alexander-schranz deleted the bugfix/debug-router-problems branch November 27, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants