Improved cache-invalidation for categories/tags in excerpt tab #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febe812 to
562210e
Compare
562210e to
ccf04b0
Compare
danrot
suggested changes
Feb 20, 2018
| @@ -3,3 +3,4 @@ framework: | |||
| storage_id: session.storage.mock_file | |||
| profiler: | |||
| enabled: false | |||
|
|
|||
|
|
||
| if (isset($excerpt['tags'])) { | ||
| foreach ($this->tagManager->resolveTagNames($excerpt['tags']) as $tag) { | ||
| $this->invalidationHandler->invalidateReference('tag', $tag); |
There was a problem hiding this comment.
Why do we need to invalidate the entire tag? Wouldn't it be enough to only invalidate pages which have the resulting pages/snippets/contacts whatever?
There was a problem hiding this comment.
we want to invalidate pages which uses the tag/category (for example as a filter for queries - smart-content in this case).
…cerpt tags/categories
ccf04b0 to
b8590e6
Compare
danrot
suggested changes
Feb 21, 2018
| public function invalidateReference($alias, $id) | ||
| { | ||
| foreach ($this->handlers as $handler) { | ||
| if (!$handler instanceof HandlerInvalidateStructureInterface) { |
There was a problem hiding this comment.
Shouldn't that check be HandlerInvalidateReferenceInterface?
|
@trickreich I think you should also do a rebase of your caching PR quite soon, so that you can ask @wachterjohannes for help, because I guess there will be some conflicts here. |
danrot
approved these changes
Feb 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR uses reference-store of categories and tags to invalidate pages where a smart-content uses tags/categories in the query.
To Do