Allow dynamic order of elements in webspace xmls #3764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b78f94f to
53d4da4
Compare
53d4da4 to
7090426
Compare
danrot
approved these changes
Feb 20, 2018
|
For me that change is fine, I think it makes writing these XMLs a lot easier, and I don't see any value in demanding a certain order. But just to be sure, I have requested reviews from the @sulu/core-team, if anybody has any serious concerns about this. |
|
is totally ok for me.. |
wachterjohannes
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It allow dynamic order of items in the webspace, template and format xmls.
Why?
For beginners a fix order can be a pitfall.
Example Usage
See sulu/sulu-docs#360 issue.