Overwrite 'doctrine:phpcr:workspace:import' set default to throw #3752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
141692a to
7dfe17d
Compare
7dfe17d to
d44b7c8
Compare
|
@danrot @chirimoya the phpcr-utils are only compatible with php |
d44b7c8 to
3868a95
Compare
|
|
3868a95 to
9c939fb
Compare
|
@danrot this is ready to review |
danrot
suggested changes
Feb 16, 2018
There was a problem hiding this comment.
If I checkout this change and import already existing data I get the following error:
[PHPCR\ItemExistsException]
There already is a node with uuid 51114c8d-1927-41db-82d8-16ca70e97447 in this workspace.
That's the desired behavior, right? So somebody would have to delete this data first before import it afterwards?
| @@ -64,7 +64,8 @@ | |||
| "symfony/symfony": "2.8.10", | |||
| "symfony/phpunit-bridge": "2.8.10", | |||
| "symfony/monolog-bundle": "2.8.10", | |||
| "jackalope/jackalope": "1.2.8 || 1.3.0 || 1.3.1" | |||
| "jackalope/jackalope": "1.2.8 || 1.3.0 || 1.3.1", | |||
| "phpcr/phpcr-utils": "1.2.1 - 1.2.10 || 1.3.1 || 1.3.2" | |||
There was a problem hiding this comment.
Why do we have such a strange version constraint here? Do you think 1.3.3 will already break again? Same for jackalope/jackalope, although that was already like that before.
There was a problem hiding this comment.
Ah, sry, didn't see that this is the conflict section 🙈
danrot
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR overwrites the command
doctrine:phpcr:workspace:importand set the default ofuuid-behaviortothrow.Why?
This disables the regeneration of
uuidwhile import from xml.