Skip to content

Fixed refresh preview #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2018
Merged

Fixed refresh preview #3750

merged 1 commit into from
Feb 7, 2018

Conversation

wachterjohannes
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #3748
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR fixes the preview on rerender.

Why?

When refreshing the preview it will not be rendered because of a missing state reset.

@wachterjohannes wachterjohannes changed the base branch from develop to master February 6, 2018 15:34
@wachterjohannes wachterjohannes changed the base branch from master to release/1.5 February 6, 2018 15:35
@wachterjohannes wachterjohannes force-pushed the hotfix/preview-refresh branch 3 times, most recently from 1419941 to cf6557e Compare February 6, 2018 15:37
@wachterjohannes wachterjohannes changed the base branch from release/1.5 to master February 6, 2018 15:41
@danrot danrot merged commit eeb1b6b into sulu:master Feb 7, 2018
@danrot danrot mentioned this pull request Feb 7, 2018
Closed
@wachterjohannes wachterjohannes deleted the hotfix/preview-refresh branch February 8, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danrot danrot Awaiting requested review from danrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachterjohannes @danrot