Skip to content

added default value to history property #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2018
Merged

added default value to history property #3747

merged 4 commits into from
Feb 15, 2018

Conversation

dominikmatt
Copy link
Contributor

@dominikmatt dominikmatt commented Feb 6, 2018 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Added empty array as default value on BaseRoute Entity.

Why?

Warning: Invalid argument supplied for foreach()
neutrik.lo/vendor/sulu/sulu/src/Sulu/Bundle/RouteBundle/Manager/RouteManager.php:104

Foreach is called and return value is false.

@dominikmatt dominikmatt changed the base branch from develop to master February 6, 2018 10:43
@wachterjohannes wachterjohannes merged commit 69e4d05 into sulu:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikmatt @wachterjohannes