Skip to content

Cleand-up xliff import/export component #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2018
Merged

Cleand-up xliff import/export component #3741

merged 1 commit into from
Feb 5, 2018

Conversation

wachterjohannes
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #3301
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR cleans-up the Import/Export component.

Why?

The missing uses/properties leads into an error when import/export blocks.

@wachterjohannes wachterjohannes mentioned this pull request Feb 5, 2018
Closed
@wachterjohannes wachterjohannes changed the base branch from master to release/1.5 February 5, 2018 08:32
@wachterjohannes wachterjohannes force-pushed the hotfix/xliff-export branch 6 times, most recently from 450790d to e3596eb Compare February 5, 2018 10:09
@danrot danrot merged commit c4e03cf into sulu:release/1.5 Feb 5, 2018
@danrot danrot mentioned this pull request Feb 5, 2018
Closed
@wachterjohannes wachterjohannes deleted the hotfix/xliff-export branch February 5, 2018 15:13
@danrot danrot mentioned this pull request Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@danrot danrot danrot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachterjohannes @danrot