Skip to content

Added exception when default_host is needed for sitemap generation #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2018
Merged

Added exception when default_host is needed for sitemap generation #3736

merged 1 commit into from
Feb 5, 2018

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Feb 2, 2018 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #3732, fixes #3382
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR fixes silent fail for sitemap generation.

@wachterjohannes wachterjohannes changed the base branch from master to release/1.5 February 2, 2018 12:07
@wachterjohannes wachterjohannes force-pushed the enhancement/throw-exception-on-missing-default-host branch 2 times, most recently from de6d108 to c1d2396 Compare February 2, 2018 12:08
danrot
danrot approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@danrot danrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is a conflict

@wachterjohannes wachterjohannes force-pushed the enhancement/throw-exception-on-missing-default-host branch from c1d2396 to 2f9883a Compare February 5, 2018 10:09
@wachterjohannes wachterjohannes force-pushed the enhancement/throw-exception-on-missing-default-host branch from 2f9883a to d06f483 Compare February 5, 2018 11:37
@danrot danrot merged commit 4ad767d into sulu:release/1.5 Feb 5, 2018
This was referenced Feb 5, 2018
Closed
Closed
@wachterjohannes wachterjohannes deleted the enhancement/throw-exception-on-missing-default-host branch February 5, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@danrot danrot danrot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachterjohannes @danrot