Skip to content

Set proper default locale for document-manager #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2018
Merged

Set proper default locale for document-manager #3735

merged 1 commit into from
Feb 5, 2018

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Feb 2, 2018 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #3722
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR set a proper default-locale for document-manager.

@wachterjohannes wachterjohannes changed the base branch from master to release/1.5 February 2, 2018 10:43
@wachterjohannes wachterjohannes force-pushed the enhancement/document-manager-default-locale branch 2 times, most recently from e3afe00 to edee4fe Compare February 2, 2018 10:45
danrot
danrot approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@danrot danrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is a conflict 😉

@wachterjohannes wachterjohannes force-pushed the enhancement/document-manager-default-locale branch from edee4fe to e08cd52 Compare February 5, 2018 10:08
@danrot danrot merged commit 1a9e958 into sulu:release/1.5 Feb 5, 2018
@danrot danrot mentioned this pull request Feb 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@danrot danrot danrot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachterjohannes @danrot