Fix retina flag in XmlFormatLoader11 & add tests for retina flag #3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wimvds we would like to introduce that in 1.5 & 1.6 could you please change the target to |
|
Ok, screwed up first by trying to change the base branch via the GitHub UI. Should be ok now :p. |
|
@wimvds thanks but could you please fixe the conflicts? |
|
Done! |
|
@wimvds 👍 thanks! one little thing please add following line to * dev-release/1.5
* BUGFIX #3693 [MediaBundle] Fix retina flag in XmlFormatLoader11 & add tests for retina flag |
|
Ok, done. |
|
@wimvds thanks for contribution :) this will go into the next release |
|
Cool! Just noticed it by accident while preparing my presentation on Sulu (while checking the new XML config format), and it was an easy fix. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR fixes loading of XML file if you set the retina flag to true.
Why?
Because it always set the retina flag to false, instead of using the value from the XML.