Fix structure internal flag and add webspace validate command #3639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14178ec to
634e05e
Compare
2c928a8 to
55e069b
Compare
2e8b7b0 to
499aa5f
Compare
| @@ -36,7 +36,7 @@ public function load($resource, $type = 'page') | |||
| $structure->name = $data['key']; | |||
| $structure->cacheLifetime = $data['cacheLifetime']; | |||
| $structure->controller = $data['controller']; | |||
| $structure->internal = 'true' === $data['internal']; | |||
| $structure->internal = $data['internal']; | |||
There was a problem hiding this comment.
this is a boolean and seems always set to false currently.
499aa5f to
4d73ae3
Compare
|
Backported the PR to 1.5 as I found a bug when building this feature (Internal Flag for Structure Metadata is never set to true) |
628b5c3 to
5f8f4c3
Compare
5f8f4c3 to
8d2dfa8
Compare
8d2dfa8 to
1c9a4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix structure internal flag as it is readed as boolean not string.
Also add better error message when structure metadata could not be found.
Also a command to validate the webspaces was added. It checks if the xml exists, view exists and controller exists.
Why?
Currently the excerpt.xml and other internal structure the internal flag is not correctly read and is false instead of true.
Currently error message was
Calling getProperties() on null.There was currently no way to validate the webspace configuration is ok.
Example Usage
Exception: Change default template of webspace to a none exist and run sulu:build dev.
Command:
bin/adminconsole sulu:content:validate:webspaces:Output:
BC Breaks/Deprecations
Describe BC breaks/deprecations here. (remove this section if not needed)
To Do