Skip to content

remove exception for non-Sulu user #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2017
Merged

remove exception for non-Sulu user #3404

merged 1 commit into from
Jun 14, 2017

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Jun 14, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #3389
Related issues/PRs #3042
License MIT
Documentation PR ---

What's in this PR?

This PR removes the exception when a User does not implement our UserInterface, but returns null instead.

@danrot danrot changed the base branch from develop to master June 14, 2017 05:46
@danrot danrot force-pushed the bugfix/security-subscriber-exception branch from a81544a to 689df22 Compare June 14, 2017 05:47
@danrot danrot mentioned this pull request Jun 14, 2017
Closed
@chirimoya chirimoya merged commit b355026 into sulu:master Jun 14, 2017
@danrot danrot deleted the bugfix/security-subscriber-exception branch June 14, 2017 13:31
@danrot danrot mentioned this pull request Jun 14, 2017
Closed
@alexander-schranz alexander-schranz mentioned this pull request Feb 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danrot @chirimoya