[ENHANCEMENT] Making MassiveBuild an optional dependency #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a5c91e to
96ec01b
Compare
96ec01b to
f03c349
Compare
f03c349 to
94726e8
Compare
|
Updated. The service definition for the command was not required as we already tell the MassiveBuild bundle to use the |
chirimoya
added a commit
that referenced
this pull request
Oct 31, 2014
Fixed multiple property style
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 25, 2024
* Rename ContentResolver to ContentAggregator * Add upgrade md * Rename content resolver test * Fix upgrade.md * Fix version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the massive build bundle is a hard dependency for CoreBundle because the Command extends the MassiveBuild command.
This PR makes the
sulu:buildcommand a service and only loads it if the MA BuildBundle is present.Havn't tested this yet properly, so its still WIP.