[FEATURE] Implemented content query #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $target = & $fieldsData; | ||
| } | ||
|
|
||
| if (!isset($field['property'])) { |
There was a problem hiding this comment.
Separate in own methods getRowValue& loadExtensionData ...
…content-query Conflicts: composer.json
| $this->contentTypeManager = $contentTypeManager; | ||
| $this->stopwatch = $stopwatch; | ||
|
|
||
| $this->createExtensionCache(); |
There was a problem hiding this comment.
why is it in a separate method?
There was a problem hiding this comment.
because it is used more than once!
… into hotfix/content-query
| /** | ||
| * converts a query row to an array | ||
| */ | ||
| private function rowToArray(Row $row, $locale, $webspaceKey, $routesPath, $fields) |
There was a problem hiding this comment.
This method seems to duplicate functionality from the content mapper
… into hotfix/content-query
| @@ -1610,4 +1639,269 @@ private function getUniquePath($name, NodeInterface $parent) | |||
| return $name; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It would be good to add a comment that the code below this line relates to mapping Row data, or maybe subclass it and just have the public methods here.
|
Have reviewed and can merge once the tests pass |
|
@dantleech has you fixed you comments? |
|
@wachterjohannes yeah.. as you are not working today :) |
|
perfekt(= |
dantleech
added a commit
that referenced
this pull request
Sep 24, 2014
[FEATURE] Implemented content query
alexander-schranz
added a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content Query used to build queries for loading small content pieces.
Tasks:
Informations: