[ENHANCEMENT] structure tagging #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8f66ee to
32ad6b8
Compare
| /** | ||
| * @expectedException \InvalidArgumentException | ||
| */ | ||
| public function testGetUndefinedStructureStructureTag() |
There was a problem hiding this comment.
StructureStructure
|
Why haven't you fixed the stuff you have mentioned in your comments? :-) |
|
sorry, this is part of a larger part of work. its still WIP |
32ad6b8 to
fbc9f03
Compare
1 task
| */ | ||
| public function setIndexName($indexName) | ||
| public function addStructureTag(StructureTag $structureTag) |
There was a problem hiding this comment.
So we are adding support for adding tags to structures.
fbc9f03 to
7d1d996
Compare
| @@ -667,7 +667,7 @@ private function changeState( | |||
| $oldState = $node->getPropertyValue($statePropertyName); | |||
|
|
|||
| if ($oldState === $state) { | |||
| // do nothing | |||
| $structure->setNodeState($state); | |||
There was a problem hiding this comment.
The node state was not being set when there was no change, so media was not being indexed on updates.
There was a problem hiding this comment.
media was not updated? why that?
There was a problem hiding this comment.
the media bundle integrates with the search. it uses the PRE_SAVE event and the node state is always TEST unless this line is here.
7d1d996 to
a48f847
Compare
This PR allows structure tags to be defined in the structure template file. These tags can subsequently be used by other bundles. It also removes the unique priority constraint on tags and adds an "addTag" method to the Property class.
a48f847 to
01c6eaf
Compare
| @@ -0,0 +1,40 @@ | |||
| <?php | |||
|
|
|||
added 3 commits
September 29, 2014 11:44
…/enhanced-structure-tagging Conflicts: src/Sulu/Bundle/CoreBundle/Resources/config/content.xml
chirimoya
added a commit
that referenced
this pull request
Oct 17, 2014
Fixed template loading with empty blocks
chirimoya
added a commit
that referenced
this pull request
Oct 31, 2014
Fixed template loading with empty blocks
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 14, 2024
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows structure tags to be defined in the structure template
file. These tags can subsequently be used by other bundles.
Tasks:
Informations: