-
Notifications
You must be signed in to change notification settings - Fork 350
[ENHANCEMENT] Added shadow properties to reserved prop. names #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added shadow properties to list of reserved property names in TemplateReader
As noted before I think we can just namespace system properties and then we can remove the concept of "reserved properties", wdyt? |
Actually we already had namespaced these properties, why did we actually remove them? Was that because of the |
After a discussion with @chirimoya we concluded that we removed the namespace because we already have this |
So what would be your ideal proposition? To have both Magnolia, I think, do not namespace normal "data", and they prefix I18N properties with |
I would go only with the |
Well, as you say, if it should be changed we should change it before 1.0 - but we should collect all such changes into as few releases as possible and provide a migration script. There is also a command which allows you to apply a closure to all nodes:
For example. |
If the migration script is quite simple it's maybe an option. @chirimoya WDYT? |
…erved [ENHANCEMENT] Added shadow properties to reserved prop. names
* introduced broken template message * fixed translations * added js-doc * used correct translation
Added shadow properties to list of reserved property names in
TemplateReader