Skip to content

[ENHANCEMENT] Added shadow properties to reserved prop. names #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2014

Conversation

dantleech
Copy link
Contributor

Added shadow properties to list of reserved property names in
TemplateReader

Added shadow properties to list of reserved property names in
TemplateReader
@dantleech
Copy link
Contributor Author

As noted before I think we can just namespace system properties and then we can remove the concept of "reserved properties", wdyt?

@danrot
Copy link
Contributor

danrot commented Sep 18, 2014

Actually we already had namespaced these properties, why did we actually remove them? Was that because of the i18n-namespace? /cc @wachterjohannes @chirimoya

@danrot danrot changed the title Added shadow properties to reserved prop. names [ENHANCEMENT] Added shadow properties to reserved prop. names Sep 29, 2014
@danrot
Copy link
Contributor

danrot commented Sep 29, 2014

After a discussion with @chirimoya we concluded that we removed the namespace because we already have this i18n-namespace. Actually we don't want to have this namespace at all, so that we could use a sulu-namespace to differ between system and non-system porperties. However, it's not that easy to change anymore...

@dantleech
Copy link
Contributor Author

So what would be your ideal proposition? To have both i18n and sulu namespaces? I would be tempted to have three, sulu, sulu, sulu-data and sulu-data-i18n but @chirimoya raused a valid point about storage capacity.

Magnolia, I think, do not namespace normal "data", and they prefix I18N properties with i18n I think. I forget how they handle system properties, we should have a look.

@danrot
Copy link
Contributor

danrot commented Sep 29, 2014

I would go only with the sulu-prefix, and don't prefix the language separately, since I don't see the advantage of it. But as already said it's not that easy to change anymore...

@dantleech
Copy link
Contributor Author

Well, as you say, if it should be changed we should change it before 1.0 - but we should collect all such changes into as few releases as possible and provide a migration script. There is also a command which allows you to apply a closure to all nodes:

$ php app/console doctrine:phpcr:node:update -q "SELECT * FROM [sulu:content]` --closure="function ($node) { foreach ($node->getProperties() as $property) { ... }"

For example.

@danrot
Copy link
Contributor

danrot commented Sep 30, 2014

If the migration script is quite simple it's maybe an option. @chirimoya WDYT?

wachterjohannes added a commit that referenced this pull request Sep 30, 2014
…erved

[ENHANCEMENT] Added shadow properties to reserved prop. names
@wachterjohannes wachterjohannes merged commit 98ed86b into develop Sep 30, 2014
@wachterjohannes wachterjohannes deleted the enhancement/added-shadow-to-reserved branch September 30, 2014 08:23
alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this pull request Nov 14, 2024
* introduced broken template message

* fixed translations

* added js-doc

* used correct translation
alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants