[FEATURE] Extracted xpathes #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can create an abstract TemplateReader, instead inheriting from the one for the content templates. |
| @@ -38,7 +42,7 @@ class TemplateReader implements LoaderInterface | |||
| * TODO should be possible to inject from config | |||
| * @var array | |||
| */ | |||
| private $reservedPropertyNames = array( | |||
| protected $reservedPropertyNames = array( | |||
| 'template', | |||
| 'changer', | |||
| 'changed', | |||
There was a problem hiding this comment.
btw. should we add shadow-on, shadow-base etc. to these names? I guess ultimately we should refactor so that they live in a different NS.
|
@danrot @dantleech i think this is solved by an other way (read snippet types) so we can close this |
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 14, 2024
* added config value to decorate index name * updated sulu
alexander-schranz
added a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.