Skip to content

[BUGFIX] Invalid resource locator produced on invalid localization #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2014

Conversation

dantleech
Copy link
Contributor

Fixes #192
Tasks:

  • test coverage
  • gather feedback for my changes

Informations:

Q A
Tests pass? yes
BC Breaks no
Doc

@wachterjohannes
Copy link
Member

@danrot code looks for me ok? could you check this against the issue i have not followed the discussions!

@danrot
Copy link
Contributor

danrot commented Sep 15, 2014

Looks good, the problem was that a URL like example.org/de-at was matched against the localization de (only if there was no de-at), so that the resource locator part started with -at. If that does not happen anymore, it's ok.

@wachterjohannes
Copy link
Member

@danrot can i merge it?

@danrot
Copy link
Contributor

danrot commented Sep 15, 2014

If what I have just described works, yes

wachterjohannes added a commit that referenced this pull request Sep 15, 2014
[BUGFIX] Invalid resource locator produced on invalid localization
@wachterjohannes wachterjohannes merged commit 56245f3 into develop Sep 15, 2014
@wachterjohannes wachterjohannes deleted the bugfix/ghi-192 branch September 15, 2014 11:03
alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this pull request Nov 14, 2024
alexander-schranz added a commit to alexander-schranz/sulu that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PCM] Wrong resource locator when using non-supported localization
3 participants