Page list security #1369
Page list security #1369
Conversation
dc5097d to
11d3242
Compare
|
@dantleech I am having a small issue with the |
733c47a to
4ea19e7
Compare
| 'name' => $this->adminName, | ||
| 'locales' => $this->locales, | ||
| 'suluVersion' => $this->suluVersion, | ||
| 'user' => json_decode( |
There was a problem hiding this comment.
Couldn't find a better solution ATM... It would be awesome if the serializer would support arrays, but AFAIK it doesn't ...
6034992 to
1271a22
Compare
| $permissions = []; | ||
| foreach ($node->getProperties('sec:*') as $property) { | ||
| /** @var PropertyInterface $property */ | ||
| $roleName = 'ROLE_' . strtoupper(str_replace('-', '_', substr($property->getName(), 4))); |
There was a problem hiding this comment.
extract 'ROLE_' into a const.
|
@danrot it works for new saved permissions but not with old ones ... i think we should provide a migration! |
1aa7b2d to
f82b65a
Compare
|
The migrations would definitely make sense, but I won't be able to implement that before coming back from holiday. |
|
@chirimoya what did you think? should we merge it without migration or should we wait until daniel is back from holiday? |
|
@wachterjohannes we should wait for the migrations. /cc @danrot |
3bf1375 to
0aad0aa
Compare
068be00 to
ad67b73
Compare
ee14731 to
8b02754
Compare
9789041 to
e2615d0
Compare
|
if your not allowed to view a page you can double click on the name and get an 403 error. also i can change the permission of a page where i have only view rights ... |
|
@danrot the rest seems to work after created saving and copying a few pages! |
|
You can change the permission if you have the security permission for the given security context. But the double click is really a bug... |
|
The bug with the double needs also a husky change: massiveart/husky#526 |
This PR considers the security of documents in the API and therefore in the column navigation.
Merge together with massiveart/husky#516 and sulu/sulu-document-manager#30 (tests won't run before)
tasks:
informations: