Update web profiler and framework bundle recipe updates #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Update web profiler and framework bundle recipe updates.
Why?
New recipe versions are available.
Unchanged
APP_SECRETin the.envfile. While this sure make sense it would be require a good documentation that now the Hosters and OP Teams need to define the APP_SECRET in the .env.local or via own ENV var. Also if the kernel.secret is used for encryption and decryption it maybe make issues if you sync databases between stage and prod envs if its not the same. So I currently keep our old APP_SECRET handling. We still should apply the changes for 3.0 version to be still as near to Symfony as possible, but for 2.6 I think its a to hard change. /cc @sulu/core-developer