Mailchimp List Select #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
I've made some tests by using this repo/branch. All seems okay. Although, re-base is needed. @markusmoosbrugger could you rebase and push it again? (not sure about github's rebase in web gui) |
|
@markusmoosbrugger @vladimirdjuricic I will rebase it today and have a look at it. |
7cecc12 to
37e24e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds a
MailchimpListSelecthelper class which is used in thefield_mailchimp.xmlto load the mailchimp lists and display them in a single select field. The mailchimp lists are loaded in the helper class in the same way as previously in theMailchimpTypeclass.Furthermore the property
attributesis removed in theFormFieldTypeConfigurationbecause it is not used anymore by any dynamic type.The changes in this PR are not properly tested yet.
Why?
The
field_mailchimp.xmlneeds to load the mailchimp lists dynamically for a given account defined by the API key.Example Usage
BC Breaks/Deprecations
Describe BC breaks/deprecations here. (remove this section if not needed)
To Do