Upgrade to Sulu 2.0 Metadata #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
14 tasks
danrot
suggested changes
Aug 9, 2019
danrot
approved these changes
Aug 9, 2019
added 18 commits
August 9, 2019 10:01
Changes in sulu core required
22d3483 to
54289cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds a FormMetadataLoader which is responsible for loading the form metadata for the form form_details.
The exceptional characteristic of this form metadata is, that a part of it is loaded via the typical FormXmlLoader and the other part (section form fields) is loaded dynamically for each form field which is included in the FormFieldTypePool.
The class DynamicFormMetadataLoader implements the FormMetadataLoaderInterface and has been tagged in the services.xml file in order to get injected into the existing FormMetadataProvider. For this functionality Sulu Core changes are required (see PR sulu/sulu#4643).
Why?
Provide a custom FormMetadataLoader which loads the form fields dynamically.
BC Breaks/Deprecations
Describe BC breaks/deprecations here. (remove this section if not needed)
To Do