-
Notifications
You must be signed in to change notification settings - Fork 78
Description
Q | A |
---|---|
Bug? | no |
New Feature? | yes |
Bundle Version | for 2.0 |
Sulu Version | for 2.0 |
Browser Version | Browser name and version |
Changes
- 1. Implement new List of Forms (implemented in Upgrade Roadmap to Sulu 2.0 compatibility #190)
Remove fieldsAction and create list xml for forms.
- 2. Implement form for forms (implemented in Upgrade Roadmap to Sulu 2.0 compatibility #190)
Create form without fields section.
- 3. Extend FormMetadataProvider (Sulu Core changes needed) (implemented in Upgrade to Sulu 2.0 Metadata #192)
EvaluateFormItemExpressions should be an own service?
MetadataProviderRegistry should handle Providers as chain so an own Provider can be implemented to add the FormMetaData for the Fields blocks.
Extend sulu to have multiple form meta data loaders and create a custom one in the form bundle to load the form_details form.
- 4. Dynamic List Fields implementation for Data Tab (Sulu Core changes needed) (implemented in Upgrade to Sulu 2.0 - Dynamic List #197)
We need a option in the RouteBuilder which does made it possible to add parameters to the metadata request. So the ListMetaProvider chain get this options and can dynamically add FieldDescriptors.
Use addRouterAttributesToListMetadata ... ['id' => 'id']
Use addRouterAttributesToListStore to add a filter for this list.
- 5. Page Tab (Add admin for dynamics form data lists #211)
Register a new route for Pages and set the tabCondition dynamically over loadedStructureMetadata to add the tab only for this structures which has the single_form_selection content type.
Use addRouterAttributesToListStore to add a filter for this list.
- 6. Database
Currently there is a strange mix about data when having a look at Dynamic.orm.xml
https://github.com/sulu/SuluFormBundle/blob/1.0.0-RC7/Resources/config/doctrine/Dynamic.orm.xml
The entity should be reduced to some basic fields:
- id: int
- (uuid: string)
- type (maybe resourceKey): string
- typeId (maybe resourceId): string
- locale: ?string (5)
- webspaceKey: ?string (64)
- typeName (maybe resourceName / resourceTitle): ?string (128)
- data: array
- auditableFields
- form: relation to form
For this all other fields need to be migrated into data field json, fields should only be set in data when the column have data for it.
This will also fix the MySQL 8 Incompatibility see #199
- 7. Dynamic.php Avoid magic setter and getter in dynamic form #255
The magic function and the geter and setters should be removed and should not longer exist:
https://github.com/sulu/SuluFormBundle/blob/1.0.0-RC7/Entity/Dynamic.php#L244-L287
- 8. Controller Dependency Injection Move controller to dependency injection #252
Controller need to be changed to dependency injection.
- 9. Event Dispatcher Update Update event dispatching #253
https://symfony.com/blog/new-in-symfony-4-3-simpler-event-dispatching
-
10. Mailchimp List Select Mailchimp List Select #198
-
11. Add .editorconfig file
-
12. Configure php-cs-fixer
-
13. Install and configure phpstan
-
14. Use yaml as format for route configuration