Fix incompatibility with the get_image twig function from sulu/web-twig package #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
approved these changes
May 29, 2024
|
@dev-newvisibility Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
We've noticed that icons and images from the article excerpt are not compatible with the twig function
get_imageof the sulu/web-twig package. This PR fixes that (a re-index is required after applying the patch).Why?
At the moment every image is treated as a jpeg (including SVG) because the mime type is not indexed in ES.
The
ImageExtensionneeds to know the MIME type of the image in order to render the appropriate html tag: https://github.com/sulu/web-twig/blob/4ed8fda8b0632082ebb16a70c4e94131a9ec648f/src/ImageExtension.php#L571