Skip to content

Conversation

martinlagler
Copy link
Contributor

@martinlagler martinlagler commented Dec 21, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs sulu/sulu#7238
License MIT

What's in this PR?

Add new updated date field to the settings tab, with a toggler to enable and disable it.

Why?

So articles can have a editable update date.

@martinlagler martinlagler force-pushed the feature/settings-updated-date branch from d597b39 to 69908e5 Compare December 21, 2023 08:26
@martinlagler martinlagler force-pushed the feature/settings-updated-date branch 3 times, most recently from 173a923 to 3d4199f Compare January 11, 2024 12:37
Copy link
Member

@wachterjohannes wachterjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is BC break - we leave this PR open

@martinlagler martinlagler force-pushed the feature/settings-updated-date branch from 3d4199f to d0d4cf5 Compare January 24, 2024 13:46
@martinlagler martinlagler force-pushed the feature/settings-updated-date branch 2 times, most recently from de021fe to 1338a09 Compare February 7, 2024 09:33
@martinlagler
Copy link
Contributor Author

@wachterjohannes I added the lastModified to the sitemap in this PR as well (f0e9920)

And i noticed that currently the date is not working on the sitemap, because the wrong paramter was set. I will also create a PR for 2.5

@alexander-schranz alexander-schranz changed the base branch from 2.5 to 2.6 March 29, 2024 13:23
@alexander-schranz alexander-schranz added the Feature New functionality not yet included label Mar 29, 2024
@alexander-schranz alexander-schranz force-pushed the feature/settings-updated-date branch from 0bd6ae5 to 8bc61ff Compare June 7, 2024 07:23
@alexander-schranz alexander-schranz changed the title Add updated date to settings tab Add last modified date to settings tab Jun 7, 2024
@alexander-schranz alexander-schranz force-pushed the feature/settings-updated-date branch 2 times, most recently from aa83fea to e9be775 Compare June 7, 2024 07:47
@alexander-schranz alexander-schranz force-pushed the feature/settings-updated-date branch 2 times, most recently from 98474c7 to afeb1d8 Compare June 7, 2024 07:53
@alexander-schranz alexander-schranz force-pushed the feature/settings-updated-date branch from afeb1d8 to dd3b40b Compare June 7, 2024 07:57
@alexander-schranz
Copy link
Member

I added the bc layer so it still works for Sulu 2.4, 2.5 and 2.6 has this new feature then enabled.

See changes in: 4230b77...fe5c433

@alexander-schranz alexander-schranz marked this pull request as ready for review June 7, 2024 10:45
@alexander-schranz alexander-schranz merged commit 8abc1e8 into 2.6 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants