Small visual tweak for signature help popup #2358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little tweak which adds a
<kbd>tag for the keyboard keys and also a<body>tag1 with unique id for the signature help popup.I have adjusted the CSS style for the
<kbd>tag a bit, beacause the default style from mdpopups uses a too high contrast against the background color in my opinion. The style will also apply to regular hover popups if they contain literal<kbd>HTML tags.<kbd>Footnotes
The
<body>tag will not be the outermost tag in the minihtml, because mdpopups still adds its own<div>wrapper tag around it, but there is nothing we can do about that and it won't affect the functionality. ↩