Bug fixes for V1BankAccounts and V1Cards services
#2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V1BankAccounts and V1Cards services
xavdid-stripe
approved these changes
Aug 1, 2025
Fair point. In this case, these methods were basically broken, so any user attempting to use them would have received an error like that reported in #2093. Not sure how much gory detail to add there, but I will mention that they were previously broken altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In #2093, it was brought to our attention that there was a bug in the
stripe.Client.V1BankAccountsservice'sCreatemethod. It turns out there were actually a few bugs in both theV1BankAccountsandV1Cardsservices, which are non-standard Stripe services that we did not correctly port over to the newstripe.Clientpattern.What?
BankAccountCreateParamsandCardCreateParamsCreateandListmethods inV1BankAccountsandV1Cardsservices.nil-checking toRetrieve,Update, andDeletemethods inV1BankAccountsandV1Cardsservices.See Also
Changelog
CreateandListmethods inV1BankAccountsandV1Cardsservices in thestripe.Clientpattern, which were previously returning errors on any valid inputs.