Skip to content

Deduplicate telemetry strings #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Conversation

mbroshi-stripe
Copy link
Contributor

Why?

It was previously possible, and occasionally seen in real usage, that a telemetry string could be duplicated when sent to Stripe (e.g. stripe_client,stripe_client,stripe_client). This could lead to very long usage strings that could eventually affect performance and hit payload limits.

What?

  • Deduplicates usage arrays

Changelog

  • Fixes a bug where telemetry strings could have duplicate values

@mbroshi-stripe mbroshi-stripe requested a review from a team as a code owner May 30, 2025 13:44
@mbroshi-stripe mbroshi-stripe requested review from helenye-stripe and removed request for a team May 30, 2025 13:44
@prathmesh-stripe
Copy link
Contributor

Just a lint failure

@mbroshi-stripe mbroshi-stripe merged commit 91aebf7 into master May 30, 2025
10 checks passed
@mbroshi-stripe mbroshi-stripe deleted the mbroshi/deduplicate-usage-strings branch May 30, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants