Reenable staticcheck and fix linting errors #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mbroshi-stripe merged 2 commits into master from mbroshi/reenable-u1000

May 8, 2025

Contributor

mbroshi-stripe commented May 5, 2025 •

edited

Loading

Why?

I needed to temporarily disable the staticcheck unused variable check before stripe.Client went live. It's live now.

What?

Reenable the unused variable staticcheck check
Always do params nil-check first to prevent possible nil-pointer dereference
Clean up some variable names

See Also


          Reenable staticcheck U1000

b58d297

mbroshi-stripe requested a review from a team as a code owner

May 5, 2025 21:31

mbroshi-stripe requested review from prathmesh-stripe and removed request for a team

May 5, 2025 21:31

prathmesh-stripe approved these changes

View reviewed changes

Contributor

prathmesh-stripe left a comment

👍 but CI Lint is now failing


          Fix linting errors

808e621

mbroshi-stripe changed the title ~~Reenable staticcheck U1000~~ Reenable staticcheck and fix linting errors

mbroshi-stripe merged commit 60506e0 into master

10 checks passed

mbroshi-stripe deleted the mbroshi/reenable-u1000 branch

May 8, 2025 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet